Skip to content

Conversation

@andygrove
Copy link
Member

Which issue does this PR close?

N/A

Rationale for this change

Native shuffle was not reporting spill metrics correctly. They were not appearing in the task metrics.

With this PR:

metrics

What changes are included in this PR?

How are these changes tested?


fn spill(&mut self) -> Result<()> {
log::debug!(
log::info!(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes logging consistent with JVM shuffle

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.85%. Comparing base (f09f8af) to head (cccb6f9).
⚠️ Report is 849 commits behind head on main.

Files with missing lines Patch % Lines
...t/execution/shuffle/CometNativeShuffleWriter.scala 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3197      +/-   ##
============================================
+ Coverage     56.12%   59.85%   +3.72%     
- Complexity      976     1415     +439     
============================================
  Files           119      168      +49     
  Lines         11743    15589    +3846     
  Branches       2251     2590     +339     
============================================
+ Hits           6591     9331    +2740     
- Misses         4012     4948     +936     
- Partials       1140     1310     +170     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove marked this pull request as ready for review January 15, 2026 23:25
Copy link
Contributor

@mbutrovich mbutrovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andygrove! This is helpful for debugging production workloads!

@mbutrovich mbutrovich merged commit 6c34c7a into apache:main Jan 16, 2026
118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants