feat(spark): implement Spark date_diff function
#19845
Open
+223
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
approved these changes
Jan 16, 2026
martin-g
reviewed
Jan 16, 2026
| SELECT date_diff(column1, column2) | ||
| FROM VALUES | ||
| ('2009-07-30'::date, '2009-07-31'::date), | ||
| ('2009-07-31'::date, '2009-07-30'::date), |
Member
There was a problem hiding this comment.
Does it make sense to add a test case for different input types ?
E.g. a Date and a String:
Suggested change
| ('2009-07-31'::date, '2009-07-30'::date), | |
| ('2009-07-31'::date, '2009-07-30'::date), | |
| ('2009-07-31'::date, '2009-07-30'), |
Member
There was a problem hiding this comment.
and also a Timestamp and a Date
Suggested change
| ('2009-07-31'::date, '2009-07-30'::date), | |
| ('2009-07-31 23:45:01'::timestamp, '2009-07-30'::date), |
|
|
||
| fn invoke_with_args(&self, _args: ScalarFunctionArgs) -> Result<ColumnarValue> { | ||
| internal_err!( | ||
| "spark date_diff should have been simplified to standard subtraction" |
Member
There was a problem hiding this comment.
Suggested change
| "spark date_diff should have been simplified to standard subtraction" | |
| "Spark `date_diff` should have been simplified to standard subtraction" |
I am not sure whether ASF branding rules should be obeyed here. Usually all Apache projects should be referred with Apache in front, i.e. Apache Spark ...
| Ok(ExprSimplifyResult::Simplified(binary_expr( | ||
| end.cast_to(&DataType::Int32, info.schema())?, | ||
| Operator::Minus, | ||
| start.cast_to(&DataType::Int32, info.schema())?, |
Member
There was a problem hiding this comment.
What if the argument data type is Date64 ? The signature allows it.
Date32 keeps the seconds since epoch, but Date64 keeps the milliseconds since epoch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-sparkSpark Compatible Functions #15914Rationale for this change
Add support for spark https://spark.apache.org/docs/latest/api/sql/index.html#date_diff function
What changes are included in this PR?
Are these changes tested?
yes in SLT
Are there any user-facing changes?
yes