Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The previous implementation used UUID-based aliasing as a workaround to prevent duplicate names for literals in Substrait plans. This approach had several drawbacks:
uuidcrateWhat changes are included in this PR?
schema_name()andqualified_name()separately, ensuring uniqueness across both naming dimensionsuuidcrate fromdatafusion/substraitproject_rel.rsis no longer needed as the improved NameTracker handles all naming conflicts consistently__temp__Nsuffixes instead of random UUIDsNote: This doesn't fully fix all the issues in #17508 which allow some special casing of
CASTwhich are not included here.Are these changes tested?
Yes:
Utf8("people")__temp__0instead of UUID-based names)Are there any user-facing changes?
Minimal. The generated plan names are now deterministic and more readable (using
__temp__Nsuffixes instead of UUIDs), but this is primarily an internal representation change. The functional behavior and query results remain unchanged.