bench: add benchmarks for first_value, last_value#21409
Merged
alamb merged 2 commits intoapache:mainfrom Apr 7, 2026
Merged
Conversation
theirix
changed the title
alamb
approved these changes
Apr 7, 2026
Contributor
|
Thank you @theirix |
Dandandan
pushed a commit
to Dandandan/arrow-datafusion
that referenced
this pull request
Apr 8, 2026
## Which issue does this PR close? ## Rationale for this change Spin-off of apache#21383 to have a bench for `First_Value`, `Last_Value` available before a PR with logic change. ## What changes are included in this PR? - Add benchmark for `GroupsAccumulator`. It's pretty complicated to test aggregates with grouping, since many operations are stateful, so I introduced end-to-end evaluate test (to actually test taking state) and convert_to_state (as in other benches) - A bench for a simple `Accumulator` ## Are these changes tested? - Manual bench run ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Spin-off of #21383 to have a bench for
First_Value,Last_Valueavailable before a PR with logic change.What changes are included in this PR?
GroupsAccumulator. It's pretty complicated to test aggregates with grouping, since many operations are stateful, so I introduced end-to-end evaluate test (to actually test taking state) and convert_to_state (as in other benches)AccumulatorAre these changes tested?
Are there any user-facing changes?