feat: support '>', '<', '>=', '<=', '<>' in all operator#21416
Open
buraksenn wants to merge 2 commits intoapache:mainfrom
Open
feat: support '>', '<', '>=', '<=', '<>' in all operator#21416buraksenn wants to merge 2 commits intoapache:mainfrom
buraksenn wants to merge 2 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Related with #20830 all operator does not support operators above.
What changes are included in this PR?
Adds support for other expressions and add tests
This is a question actually I've checked behaviors of Postgresql and Duckdb about null semantics and continued with the Postgresql behavior. However, I'm not sure if we want this so also put Duckdb outputs. It would be great to have feedback on this
5 = ANY(NULL::INT[])NULLNULLfalse5 <> ANY(NULL::INT[])NULLNULLfalse5 > ANY(NULL::INT[])NULLNULLfalse5 < ANY(NULL::INT[])NULLNULLfalse5 >= ANY(NULL::INT[])NULLNULLfalse5 <= ANY(NULL::INT[])NULLNULLfalse5 = ALL(NULL::INT[])NULLNULLtrue5 > ALL(NULL::INT[])NULLNULLtrue5 < ALL(NULL::INT[])NULLNULLtrueAre these changes tested?
Added slt tests for this and they all pass
Are there any user-facing changes?
Yes user's can now use all operator with this new expressions