[ut](filecache) fix bvar::Window metrics use-after free#59958
Merged
hello-stephen merged 1 commit intoapache:masterfrom Jan 19, 2026
Merged
[ut](filecache) fix bvar::Window metrics use-after free#59958hello-stephen merged 1 commit intoapache:masterfrom
hello-stephen merged 1 commit intoapache:masterfrom
Conversation
Disable creation of these Window metrics for UT (keep only Adder/Status) to prevent sampling threads from being involved. Otherwise, BlockFileCache class can be destroyed before sampling threads join make it Use-After-Free. Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
TPC-H: Total hot run time: 31845 ms |
TPC-DS: Total hot run time: 173782 ms |
ClickBench: Total hot run time: 26.72 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
approved these changes
Jan 19, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
gavinchou
approved these changes
Jan 19, 2026
Contributor
|
skip check_coverage |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 19, 2026
Disable creation of these Window metrics for UT (keep only Adder/Status) to prevent sampling threads from being involved. Otherwise, BlockFileCache class can be destroyed before sampling threads join make it Use-After-Free.
yiguolei
pushed a commit
that referenced
this pull request
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable creation of these Window metrics for UT (keep only Adder/Status) to prevent sampling threads from being involved. Otherwise, BlockFileCache class can be destroyed before sampling threads join make it Use-After-Free.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)