Skip to content

[fix](inverted index) AcceptNullPredicate should include null rows in result bitmap#59959

Merged
yiguolei merged 1 commit intoapache:masterfrom
zzzxl1993:202501161419
Jan 18, 2026
Merged

[fix](inverted index) AcceptNullPredicate should include null rows in result bitmap#59959
yiguolei merged 1 commit intoapache:masterfrom
zzzxl1993:202501161419

Conversation

@zzzxl1993
Copy link
Contributor

@zzzxl1993 zzzxl1993 commented Jan 16, 2026 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 16, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zzzxl1993
Copy link
Contributor Author

zzzxl1993 commented Jan 16, 2026

run buildall

@zzzxl1993 zzzxl1993 changed the title [fix](<inverted index>) AcceptNullPredicate should include null rows in result bitmap [fix](inverted index) AcceptNullPredicate should include null rows in result bitmap Jan 16, 2026
@doris-robot
Copy link

doris-robot commented Jan 16, 2026

TPC-H: Total hot run time: 32305 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 43e52ddbb1c816ebf6244d729374fda2e4a5017c, data reload: false

------ Round 1 ----------------------------------
q1	17644	4259	4032	4032
q2	2059	352	238	238
q3	10139	1375	750	750
q4	10214	884	306	306
q5	7522	2176	1845	1845
q6	202	169	140	140
q7	955	778	678	678
q8	9276	1438	1241	1241
q9	5024	4721	4588	4588
q10	6784	1788	1411	1411
q11	516	290	288	288
q12	710	748	613	613
q13	17767	3930	3114	3114
q14	295	296	274	274
q15	599	510	513	510
q16	698	686	644	644
q17	710	797	549	549
q18	7147	6439	7362	6439
q19	1161	1024	661	661
q20	428	383	260	260
q21	3337	2670	2694	2670
q22	1159	1082	1054	1054
Total cold run time: 104346 ms
Total hot run time: 32305 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4477	4352	4240	4240
q2	333	397	335	335
q3	2419	2735	2470	2470
q4	1524	1918	1499	1499
q5	4565	4267	4441	4267
q6	211	170	124	124
q7	2027	1923	1843	1843
q8	2617	2578	2461	2461
q9	7124	7300	7236	7236
q10	2473	2823	2334	2334
q11	562	479	460	460
q12	769	780	642	642
q13	3573	4023	3082	3082
q14	258	280	252	252
q15	524	489	484	484
q16	632	653	616	616
q17	1111	1306	1349	1306
q18	7526	7462	7097	7097
q19	913	864	820	820
q20	1880	1980	1806	1806
q21	4598	4265	4160	4160
q22	1084	1067	1003	1003
Total cold run time: 51200 ms
Total hot run time: 48537 ms

@doris-robot
Copy link

doris-robot commented Jan 16, 2026

TPC-DS: Total hot run time: 175513 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 43e52ddbb1c816ebf6244d729374fda2e4a5017c, data reload: false

query5	4424	627	489	489
query6	335	241	219	219
query7	4219	470	267	267
query8	343	267	253	253
query9	8685	3055	3078	3055
query10	496	382	334	334
query11	15375	15123	14757	14757
query12	182	118	117	117
query13	1264	489	398	398
query14	6101	3058	2730	2730
query14_1	2673	2775	2649	2649
query15	199	194	175	175
query16	990	494	486	486
query17	1133	678	575	575
query18	2459	438	344	344
query19	227	223	192	192
query20	122	117	119	117
query21	214	139	120	120
query22	4332	4404	4399	4399
query23	16308	15703	15380	15380
query23_1	15608	15481	15527	15481
query24	7138	1585	1178	1178
query24_1	1197	1189	1180	1180
query25	555	461	414	414
query26	1254	280	158	158
query27	2735	458	287	287
query28	4551	2142	2143	2142
query29	768	546	448	448
query30	308	243	210	210
query31	816	646	602	602
query32	90	75	79	75
query33	572	346	300	300
query34	917	887	562	562
query35	713	748	680	680
query36	886	940	816	816
query37	150	101	87	87
query38	2706	2685	2649	2649
query39	790	768	734	734
query39_1	706	712	721	712
query40	220	132	124	124
query41	71	63	61	61
query42	105	101	101	101
query43	458	475	430	430
query44	1316	732	746	732
query45	186	187	174	174
query46	843	950	570	570
query47	1477	1533	1469	1469
query48	337	330	263	263
query49	614	437	344	344
query50	642	272	213	213
query51	3821	3811	3853	3811
query52	107	107	99	99
query53	298	321	279	279
query54	289	268	275	268
query55	88	85	82	82
query56	351	314	318	314
query57	1071	1056	929	929
query58	280	263	260	260
query59	2166	2234	2206	2206
query60	360	345	326	326
query61	159	157	152	152
query62	416	357	319	319
query63	294	270	270	270
query64	4876	1264	985	985
query65	3922	3837	3757	3757
query66	1451	431	323	323
query67	15627	15683	15527	15527
query68	2465	1120	789	789
query69	469	353	334	334
query70	1062	997	978	978
query71	321	322	298	298
query72	5337	3191	3309	3191
query73	616	745	344	344
query74	8761	8734	8643	8643
query75	2712	2821	2466	2466
query76	2272	1108	658	658
query77	378	378	320	320
query78	9821	9882	9229	9229
query79	2999	910	578	578
query80	1728	582	481	481
query81	579	266	240	240
query82	993	155	114	114
query83	339	277	253	253
query84	264	116	95	95
query85	921	519	440	440
query86	498	330	289	289
query87	2918	2891	2757	2757
query88	3581	2562	2526	2526
query89	395	345	326	326
query90	2087	177	166	166
query91	175	160	138	138
query92	86	82	72	72
query93	2181	932	536	536
query94	655	324	301	301
query95	600	328	389	328
query96	660	510	235	235
query97	2379	2385	2334	2334
query98	230	209	211	209
query99	605	621	523	523
Total cold run time: 252669 ms
Total hot run time: 175513 ms

@doris-robot
Copy link

doris-robot commented Jan 16, 2026

ClickBench: Total hot run time: 27.47 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 43e52ddbb1c816ebf6244d729374fda2e4a5017c, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.04
query3	0.26	0.09	0.09
query4	1.61	0.12	0.11
query5	0.29	0.25	0.25
query6	1.15	0.67	0.68
query7	0.03	0.02	0.02
query8	0.06	0.05	0.05
query9	0.57	0.51	0.52
query10	0.56	0.55	0.56
query11	0.15	0.10	0.11
query12	0.15	0.10	0.11
query13	0.61	0.59	0.59
query14	0.96	0.96	0.97
query15	0.78	0.78	0.78
query16	0.40	0.41	0.42
query17	1.06	1.09	1.05
query18	0.24	0.21	0.21
query19	1.91	1.85	1.96
query20	0.02	0.01	0.02
query21	15.46	0.28	0.14
query22	4.87	0.06	0.05
query23	15.72	0.29	0.10
query24	0.98	0.68	0.60
query25	0.11	0.09	0.07
query26	0.14	0.15	0.13
query27	0.10	0.06	0.06
query28	4.84	1.07	0.88
query29	12.54	4.14	3.27
query30	0.28	0.14	0.11
query31	2.82	0.68	0.40
query32	3.24	0.55	0.47
query33	2.91	3.10	3.09
query34	16.17	5.09	4.41
query35	4.45	4.49	4.43
query36	0.65	0.51	0.50
query37	0.12	0.07	0.06
query38	0.08	0.05	0.04
query39	0.05	0.03	0.03
query40	0.17	0.15	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 96.84 s
Total hot run time: 27.47 s

@doris-robot
Copy link

doris-robot commented Jan 16, 2026

BE UT Coverage Report

Increment line coverage 100.00% (15/15) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.43% (19043/36319)
Line Coverage 35.73% (176392/493731)
Region Coverage 32.26% (136590/423366)
Branch Coverage 33.16% (59042/178073)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 16, 2026

BE Regression && UT Coverage Report

Increment line coverage 100.00% (15/15) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.38% (25373/35546)
Line Coverage 53.88% (265710/493107)
Region Coverage 51.50% (220251/427662)
Branch Coverage 52.93% (94654/178821)

csun5285
csun5285 approved these changes Jan 18, 2026
View reviewed changes
Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2026

PR approved by anyone and no changes requested.

eldenmoon
eldenmoon approved these changes Jan 18, 2026
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 18, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2026

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei merged commit 08b68a2 into apache:master Jan 18, 2026
30 of 37 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 18, 2026
@zzzxl1993
[fix](inverted index) AcceptNullPredicate should include null rows in…
864250f 
… result bitmap (#59959)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [x] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->


```
@github-actions github-actions bot mentioned this pull request Jan 18, 2026
Merged
yiguolei pushed a commit that referenced this pull request Jan 18, 2026
@github-actions @zzzxl1993
branch-4.0: [fix](inverted index) AcceptNullPredicate should include …
0e4faec 
…null rows in result bitmap #59959 (#59998)

Cherry-picked from #59959

Co-authored-by: zzzxl <yangsiyu@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eldenmoon eldenmoon eldenmoon approved these changes

+1 more reviewer

@csun5285 csun5285 csun5285 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zzzxl1993 @hello-stephen @doris-robot @eldenmoon @csun5285 @yiguolei