Skip to content

[fix](wg) Add lock for concurrency read#59960

Merged
yiguolei merged 1 commit intoapache:masterfrom
Gabriel39:fix_0116
Jan 18, 2026
Merged

[fix](wg) Add lock for concurrency read#59960
yiguolei merged 1 commit intoapache:masterfrom
Gabriel39:fix_0116

Conversation

@Gabriel39
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Gabriel39
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TPC-H: Total hot run time: 31887 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d5d2ca9671f5fc126f41f95bbb2f2922e2a3b8df, data reload: false

------ Round 1 ----------------------------------
q1	17599	4187	4026	4026
q2	2044	386	240	240
q3	10123	1301	706	706
q4	10204	819	298	298
q5	7528	2111	1799	1799
q6	184	172	140	140
q7	922	806	660	660
q8	9271	1402	1116	1116
q9	4864	4655	4621	4621
q10	6699	1813	1414	1414
q11	529	304	274	274
q12	698	731	598	598
q13	17770	3835	3092	3092
q14	306	294	275	275
q15	575	517	506	506
q16	677	680	635	635
q17	634	787	483	483
q18	7028	6523	6878	6523
q19	1118	1015	645	645
q20	432	375	265	265
q21	3195	2733	2550	2550
q22	1153	1074	1021	1021
Total cold run time: 103553 ms
Total hot run time: 31887 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4450	4232	4295	4232
q2	333	432	325	325
q3	2380	2849	2480	2480
q4	1449	1866	1418	1418
q5	4403	4309	4382	4309
q6	219	169	126	126
q7	2008	1938	1750	1750
q8	2689	2439	2388	2388
q9	7181	7158	7324	7158
q10	2431	2725	2350	2350
q11	550	462	455	455
q12	694	742	629	629
q13	3673	4059	3089	3089
q14	258	292	254	254
q15	525	481	491	481
q16	625	654	620	620
q17	1126	1274	1282	1274
q18	7558	7559	7349	7349
q19	827	763	782	763
q20	1868	1960	1787	1787
q21	4423	4276	4033	4033
q22	1072	1043	977	977
Total cold run time: 50742 ms
Total hot run time: 48247 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174300 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d5d2ca9671f5fc126f41f95bbb2f2922e2a3b8df, data reload: false

query5	4421	638	485	485
query6	328	220	213	213
query7	4237	494	252	252
query8	339	232	230	230
query9	8694	2855	2855	2855
query10	476	372	331	331
query11	15252	15167	14903	14903
query12	183	113	114	113
query13	1243	480	367	367
query14	5532	3030	2807	2807
query14_1	2664	2686	2657	2657
query15	209	191	173	173
query16	956	532	469	469
query17	897	686	598	598
query18	2416	446	333	333
query19	227	218	186	186
query20	116	113	112	112
query21	214	137	114	114
query22	3884	4152	3869	3869
query23	16027	15691	15374	15374
query23_1	15574	15506	15328	15328
query24	7147	1553	1152	1152
query24_1	1132	1151	1171	1151
query25	514	428	393	393
query26	1237	283	147	147
query27	2762	447	270	270
query28	4575	2118	2123	2118
query29	756	514	414	414
query30	318	243	209	209
query31	790	619	584	584
query32	80	77	76	76
query33	528	361	324	324
query34	913	915	535	535
query35	752	794	679	679
query36	885	869	806	806
query37	137	103	92	92
query38	2793	2736	2680	2680
query39	761	768	735	735
query39_1	741	737	735	735
query40	227	142	122	122
query41	70	70	67	67
query42	113	103	104	103
query43	450	482	414	414
query44	1367	733	735	733
query45	193	190	188	188
query46	865	974	573	573
query47	1449	1448	1345	1345
query48	314	325	247	247
query49	628	456	349	349
query50	641	277	206	206
query51	3748	3782	3840	3782
query52	108	110	99	99
query53	303	333	273	273
query54	312	290	284	284
query55	86	81	78	78
query56	328	346	334	334
query57	1045	1006	967	967
query58	289	265	265	265
query59	2181	2169	2092	2092
query60	361	351	326	326
query61	180	178	179	178
query62	399	348	329	329
query63	306	271	266	266
query64	5124	1396	1095	1095
query65	3868	3762	3753	3753
query66	1466	424	325	325
query67	15602	15581	15346	15346
query68	2340	1092	756	756
query69	461	372	335	335
query70	999	959	960	959
query71	326	313	286	286
query72	5263	3546	3379	3379
query73	616	755	319	319
query74	8809	8781	8538	8538
query75	2840	2807	2469	2469
query76	2267	1129	659	659
query77	373	399	325	325
query78	9821	9971	9281	9281
query79	1097	927	573	573
query80	1341	569	480	480
query81	561	271	238	238
query82	1014	148	109	109
query83	359	257	241	241
query84	302	116	91	91
query85	1049	509	454	454
query86	417	298	309	298
query87	2893	2873	2746	2746
query88	3484	2598	2547	2547
query89	399	340	328	328
query90	1906	173	168	168
query91	167	163	144	144
query92	74	75	71	71
query93	1019	941	548	548
query94	651	333	287	287
query95	595	400	312	312
query96	657	514	234	234
query97	2347	2433	2348	2348
query98	228	201	206	201
query99	598	561	492	492
Total cold run time: 247372 ms
Total hot run time: 174300 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 26.68 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d5d2ca9671f5fc126f41f95bbb2f2922e2a3b8df, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.04
query3	0.25	0.09	0.09
query4	1.61	0.12	0.11
query5	0.26	0.25	0.27
query6	1.15	0.65	0.66
query7	0.03	0.03	0.02
query8	0.06	0.04	0.04
query9	0.58	0.50	0.49
query10	0.57	0.56	0.57
query11	0.14	0.10	0.10
query12	0.14	0.10	0.11
query13	0.60	0.59	0.58
query14	0.96	0.96	0.96
query15	0.78	0.77	0.78
query16	0.39	0.38	0.40
query17	1.04	1.09	1.05
query18	0.23	0.21	0.21
query19	1.88	1.89	1.74
query20	0.02	0.01	0.01
query21	15.46	0.27	0.14
query22	5.06	0.06	0.05
query23	15.80	0.29	0.10
query24	1.84	0.52	0.18
query25	0.12	0.08	0.08
query26	0.14	0.13	0.14
query27	0.07	0.07	0.08
query28	4.72	1.08	0.89
query29	12.57	3.88	3.16
query30	0.28	0.13	0.12
query31	2.81	0.64	0.39
query32	3.24	0.56	0.45
query33	3.05	2.95	3.04
query34	15.90	5.06	4.42
query35	4.42	4.49	4.49
query36	0.64	0.50	0.51
query37	0.10	0.07	0.07
query38	0.07	0.04	0.04
query39	0.04	0.03	0.02
query40	0.17	0.14	0.14
query41	0.09	0.03	0.03
query42	0.05	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 97.52 s
Total hot run time: 26.68 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.45% (19022/36269)
Line Coverage 35.72% (176335/493688)
Region Coverage 32.24% (136427/423135)
Branch Coverage 33.15% (59021/178046)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 17, 2026
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei
Copy link
Contributor

skip check_coverage

@yiguolei yiguolei merged commit abcbb2b into apache:master Jan 18, 2026
28 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 18, 2026
yiguolei pushed a commit that referenced this pull request Jan 18, 2026
Cherry-picked from #59960

Co-authored-by: Gabriel <liwenqiang@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants