-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](hive) Fix partition values cache sync issue in Observer FE during insert #59965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng insert When Observer FE receives edit logs from Master FE after a Hive insert operation, it may miss adding new partitions to its partition values cache. This happens because: 1. When inserting into a new partition, Master FE refreshes its cache and gets the partition into its partition values cache 2. Master FE records the partition as MODIFIED (not NEW) in the edit log if it already exists in HMS 3. Observer FE processes only newPartNames when updating partition values cache, missing partitions marked as MODIFIED Fix by merging both modifiedPartNames and newPartNames before adding to the partition values cache, ensuring Observer FE stays synchronized with Master FE.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
suxiaogang223
approved these changes
Jan 16, 2026
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32205 ms |
CalvinKirs
approved these changes
Jan 17, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
TPC-DS: Total hot run time: 177343 ms |
ClickBench: Total hot run time: 27.45 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
suxiaogang223
approved these changes
Jan 17, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Jan 17, 2026
…ng insert (#59965) ### What problem does this PR solve? Related PR: #58166 Problem Summary: When Observer FE receives edit logs from Master FE after a Hive insert operation, it may miss adding new partitions to its partition values cache. This happens because: 1. When inserting into a new partition, Master FE refreshes its cache and gets the partition into its partition values cache 2. Master FE records the partition as MODIFIED (not NEW) in the edit log if it already exists in HMS 3. Observer FE processes only newPartNames when updating partition values cache, missing partitions marked as MODIFIED Fix by merging both modifiedPartNames and newPartNames before adding to the partition values cache, ensuring Observer FE stays synchronized with Master FE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #58166
Problem Summary:
When Observer FE receives edit logs from Master FE after a Hive insert operation, it may miss adding new partitions to its partition values cache. This happens because:
Fix by merging both modifiedPartNames and newPartNames before adding to the partition values cache, ensuring Observer FE stays synchronized with Master FE.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)