-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Enhance](docker) hoist IP_HOST detection and improve script robustness #59978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+3
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
CalvinKirs
previously approved these changes
Jan 16, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
hubgeter
approved these changes
Jan 16, 2026
Contributor
Author
|
run buildall |
hello-stephen
approved these changes
Jan 19, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
hubgeter
approved these changes
Jan 19, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Jan 19, 2026
…ss (#59978) ### What problem does this PR solve? 1. Move IP_HOST detection from start_hive2() to global scope to ensure environment variables are accessible by all background services. 2. Use 'ip addr' instead of 'ifconfig' for more reliable IP detection. 3. Add -f flag to rm commands in spark cleanup to prevent exit on missing files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
environment variables are accessible by all background services.
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)