FELIX-6822 Add default to Servlet Context Name#479
Open
Positronic-Brain wants to merge 1 commit intoapache:masterfrom
Open
FELIX-6822 Add default to Servlet Context Name#479Positronic-Brain wants to merge 1 commit intoapache:masterfrom
Positronic-Brain wants to merge 1 commit intoapache:masterfrom
Conversation
kwin
reviewed
Feb 18, 2026
| @interface HealthCheckExecutorServletConfiguration { | ||
|
|
||
| String SERVLET_PATH_DEFAULT = "/system/health"; | ||
| String HTTP_SERVICE_CONTEXT_NAME = "org.osgi.service.http"; |
Member
There was a problem hiding this comment.
no need to redefine this constant, just use https://docs.osgi.org/javadoc/osgi.cmpn/8.0.0/org/osgi/service/http/whiteboard/HttpWhiteboardConstants.html#HTTP_WHITEBOARD_DEFAULT_CONTEXT_NAME
kwin
suggested changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Felix 6822