FINERACT-1371: Fix hook event payload exposing wrong resourceId for C…

[SamaSVM]

Description

Fix hook event payload incorrectly exposing resourceId equal to clientId for single-row CLIENT datatable entries

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per our guidelines
• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• Create/update unit or integration tests for verifying the changes made.
• Follow our coding conventions.
• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

[IOhacker]

What about using Lombok ?

[SamaSVM]

Good point, I’ve updated it.

[adamsaghy]

I dont get these changes...

[adamsaghy]

it looks incorrect to blindly null resource id...

[adamsaghy]

I dont really understand the changes and the reasons....

Can you give me some examples and explanation?

[SamaSVM]

@adamsaghy From the task I can see that response.resourceId is always the same as response.clientId. After analysis I found that in DatatableWriteServiceImpl at line 1159 we set:

Long resourceId = appTableId;
 if (datatableUtil.isMultirowDatatable(columnHeaders)) {
     resourceId = sqlGenerator.fetchPK(keyHolder);
 }

If we don't enter the if block (single-row datatable) then resourceId = appTableId = clientId for CLIENT entity. As I understand this is the reason why response.resourceId == response.clientId.
I think the problem is in publishHookEvent where resourceId was not promoted to the root level and not cleared from response, unlike officeId.
So I decided to apply the same approach as for officeId — promote resourceId to the root level and clear it in response.

Note: I am still learning this codebase so I might have got something wrong.