[hotfix] Intermittent unit test failures we have hit in ExecutionGraph tests #27433
Open
davidradl wants to merge 5 commits intoapache:masterfrom
Open
[hotfix] Intermittent unit test failures we have hit in ExecutionGraph tests #27433davidradl wants to merge 5 commits intoapache:masterfrom
davidradl wants to merge 5 commits intoapache:masterfrom
Conversation
…wTaskDetectorTest Signed-off-by: davidradl <david_radley@uk.ibm.com>
Collaborator
snuyanzin
reviewed
Jan 19, 2026
...runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java
Outdated
Show resolved
Hide resolved
e238c2f to
2613629
Compare
Signed-off-by: david_radley@uk.ibm.com <david_radley@uk.ibm.com>
2613629 to
9ad49b0
Compare
Signed-off-by: david_radley@uk.ibm.com <david_radley@uk.ibm.com>
937ba08 to
6cec5a9
Compare
Signed-off-by: david_radley@uk.ibm.com <david_radley@uk.ibm.com>
Signed-off-by: david_radley@uk.ibm.com <david_radley@uk.ibm.com>
Contributor
Author
|
@snuyanzin Please could you look at this new approach that avoid using sleeps please. |
Contributor
Author
|
@flinkbot run azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were getting an intermittent errors in our CI pipeline,
The original change was to introduce sleeps in line with the approach the existing test take in this area. This was rightly rejected in the review. I have changed the approach to add job listeners and futures so that the tests continue when they hit the expected state, without using sleeps.