refactor(dart): aligned dart internal implementation#3601
Open
Geethapranay1 wants to merge 2 commits intoapache:mainfrom
Open
refactor(dart): aligned dart internal implementation#3601Geethapranay1 wants to merge 2 commits intoapache:mainfrom
Geethapranay1 wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@chaokunyang PTAL |
Geethapranay1
changed the title
chaokunyang
reviewed
Apr 21, 2026
| * under the License. | ||
| */ | ||
|
|
||
| abstract final class CollectionFlags { |
Collaborator
There was a problem hiding this comment.
We don't need to split it into separate files. dart file is like java package.
When align with java, it's more about implementation detailes instead of code style. We still need be dart idiomatic
Contributor
Author
There was a problem hiding this comment.
makes sense, i just now moved the flags directly into the serializer files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The dart implementation's internal collections and map serializers were previously structured differently than the java and c# runtimes, using raw hex bitmasks and monolithic methods which made reading the code difficult.
What does this PR do?
MapFlagsandCollectionFlags.ListSerializer.writePayloadinto_writeSameTypeElementsand_writeDifferentTypeElements.maxDepthspec enforcement on both read/write bounds.Related issues
Fixes #3595
AI Contribution Checklist
yes/noyes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes.Does this PR introduce any user-facing change?
Benchmark