-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29833: Fix dead links in README #7643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates links and reintroduces export control page to the website
|
🎊 +1 overall
This message was automatically generated. |
PDavid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks 👍
|
Thanks for the quick review. I built the site locally and it looks good to me. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
I wanna say this is unrelated :) |
Hmm, very strange. I asked about this error in the ASF infra Slack channel, let's see what they answer. Otherwise I checked out your branch and the site builds fine locally and the website is working. 👌 |
|
Thanks. The changes they suggest sound a bit "bigger" than the scope of this PR. |
I agree. I think you can merge this because locally it is building fine. |
|
Thanks. Will do. It's been ages since I contributed to HBase. Sorry for the newbie question. Do you usally squash and merge here? |
Exactly. Squash and merge, adjust the commit message if needed and add the "Signed-off-by" at the end of the commit message, e.g.: Many thanks Lars. 👍 |
Updates links and reintroduces export control page to the website