IGNITE-27457 Implement result output for wal enable/disable control.sh commands by VolkodamovDaniil · Pull Request #12608 · apache/ignite

VolkodamovDaniil · 2025-12-25T13:29:12Z

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

There is a single JIRA ticket related to the pull request.
The web-link to the pull request is attached to the JIRA ticket.
The JIRA ticket has the Patch Available state.
The pull request body describes changes that have been made.
The description explains WHAT and WHY was made instead of HOW.
The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
A reviewer has been mentioned through the JIRA comments
(see the Maintainers list)
The pull request has been checked by the Teamcity Bot and
the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

timoninmaxim · 2025-12-29T20:20:40Z

Please, fix merge conflicts

# Conflicts: # modules/control-utility/src/test/java/org/apache/ignite/util/GridCommandHandlerWalTest.java # modules/core/src/main/java/org/apache/ignite/internal/cluster/IgniteClusterImpl.java # modules/core/src/main/java/org/apache/ignite/internal/management/wal/WalSetStateTask.java # modules/core/src/test/java/org/apache/ignite/internal/processors/cache/WalModeChangeAdvancedSelfTest.java

timoninmaxim · 2026-01-13T12:15:43Z

modules/control-utility/src/test/java/org/apache/ignite/util/GridCommandHandlerWalTest.java

     */
    @Test
-    public void testWalChangeForMultiCacheGroup() throws Exception {
+    public void testWalManagementOperations() throws Exception {


Keep old test name

timoninmaxim · 2026-01-13T12:16:33Z

modules/control-utility/src/test/java/org/apache/ignite/util/GridCommandHandlerWalTest.java

+     * @throws Exception If failed.
+     */
+    @Test
+    public void testWalChangeForNonPersistentCaches() throws Exception {


Let's fix this behavior in different patch

timoninmaxim · 2026-01-13T12:19:42Z

modules/core/src/main/java/org/apache/ignite/internal/management/wal/WalSetStateTask.java

-        @Override protected Void run(@Nullable WalDisableCommandArg arg) throws IgniteException {
-            Set<String> grps = F.isEmpty(arg.groups()) ? null : new HashSet<>(Arrays.asList(arg.groups()));
+        @Override protected WalSetStateTaskResult run(@Nullable WalDisableCommandArg arg) throws IgniteException {
+            Set<String> requestedGrps = F.isEmpty(arg.groups()) ? null : new HashSet<>(Arrays.asList(arg.groups()));


arr -> list -> set?

Let's use List

timoninmaxim · 2026-01-13T12:23:11Z

modules/core/src/main/java/org/apache/ignite/internal/management/wal/WalSetStateTask.java

+                    }
+                }
+
+                for (String requestedGrp : requestedGrps) {


Can reuse request groups after removing

timoninmaxim · 2026-01-13T12:23:33Z

modules/core/src/main/java/org/apache/ignite/internal/management/wal/WalSetStateTask.java

+            }
+            catch (Exception e) {
+                errors.add("Failed to execute operation - " + e.getMessage());
+                return new WalSetStateTaskResult(successGrps, errors);


add NL before return

timoninmaxim · 2026-01-13T12:25:50Z

modules/core/src/main/java/org/apache/ignite/internal/management/wal/WalSetStateTask.java

+            else {
+                WalSetStateTaskResult result = jobRes.getData();
+                if (result.successGroups() != null)
+                    successGrps.addAll(result.successGroups());


You can safely reuse success groups from any response

timoninmaxim · 2026-01-13T12:26:40Z

modules/core/src/main/java/org/apache/ignite/internal/management/wal/WalSetStateTask.java

+        if (errors.isEmpty())
+            return new WalSetStateTaskResult(new ArrayList<>(successGrps));
+        else
+            return new WalSetStateTaskResult(new ArrayList<>(successGrps), errors);


make successGrps list in definition

timoninmaxim · 2026-01-13T12:27:31Z

modules/core/src/main/java/org/apache/ignite/internal/management/wal/WalSetStateTask.java

+                if (result.successGroups() != null)
+                    successGrps.addAll(result.successGroups());
+                if (!Boolean.TRUE.equals(result.success()) && result.errorMessages() != null)
+                    errors.addAll(result.errorMessages());


There are duplicates of errors

timoninmaxim · 2026-01-13T12:28:05Z

modules/core/src/main/java/org/apache/ignite/internal/management/wal/WalSetStateTaskResult.java

+    private static final long serialVersionUID = 0L;
+
+    /** Success flag. */
+    private Boolean success;


can check errors for empty.

timoninmaxim · 2026-01-14T12:11:04Z

modules/core/src/main/java/org/apache/ignite/internal/management/wal/WalDisableCommand.java

    }

+    /** {@inheritDoc} */
+    @Override public void printResult(WalDisableCommandArg arg, WalSetStateTaskResult res, Consumer<String> printer) {


Let's move logic to a separate class

timoninmaxim · 2026-01-14T12:11:56Z

modules/core/src/main/java/org/apache/ignite/internal/management/wal/WalSetStateTask.java

+            Set<String> requestedGrps = F.isEmpty(arg.groups()) ? null : new HashSet<>(Arrays.asList(arg.groups()));
+            boolean isEnable = arg instanceof WalEnableCommandArg;
+            List<String> successGrps = new ArrayList<>();
+            List<String> errors = new ArrayList<>();


Let's use map

timoninmaxim · 2026-01-14T12:12:09Z

modules/core/src/main/java/org/apache/ignite/internal/management/wal/WalSetStateTask.java

+                        successGrps.add(grpName);
+                    }
+                    catch (Exception e) {
+                        errors.add("Failed to " + (isEnable ? "enable" : "disable") +


Send only exception messages

timoninmaxim · 2026-02-09T09:21:29Z

Moved to #12711

VolkodamovDaniil added 6 commits December 10, 2025 22:36

change wal mode for multiple caches from same group

67c28e9

replace try-catch with assertThrows

e3082eb

extend validation

bcd2fc6

add test that reveals problem

dd502d4

support cache groups in change WAL methods

9f73e77

add result reporting to WAL management commands

3b993fd

VolkodamovDaniil added 4 commits December 29, 2025 23:57

remove extra newline

b6c94a8

update tests to verify commands output

dc2abe8

add test for non persistent caches

d0778e7

timoninmaxim requested changes Jan 13, 2026

View reviewed changes

use VisorOneNodeTask for WalSetStateTask

4c3feea

timoninmaxim reviewed Jan 14, 2026

View reviewed changes

move result printing to shared utility

4778664

timoninmaxim closed this Feb 9, 2026

Conversation

VolkodamovDaniil commented Dec 25, 2025

The Contribution Checklist

Notes

Uh oh!

timoninmaxim commented Dec 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

timoninmaxim commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments