Skip to content

IGNITE-28538 Remove the rejected field in MetadataRemoveProposedMessage #13021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shishkovilja merged 1 commit into from
Apr 14, 2026
+4 −10
Merged

IGNITE-28538 Remove the rejected field in MetadataRemoveProposedMessage #13021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions ...ava/org/apache/ignite/internal/processors/cache/binary/MetadataRemoveProposedMessage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,12 @@ public final class MetadataRemoveProposedMessage implements DiscoveryCustomMessa
@Order(2)
int typeId;

/** Message acceptance status. */
@Order(3)
boolean rejected;

/** Message received on coordinator. */
@Order(4)
@Order(3)
boolean onCoordinator = true;

/** */
@Order(5)
@Order(4)
String errMsg;

/** Constructor. */
Expand All @@ -83,7 +79,7 @@ public MetadataRemoveProposedMessage(int typeId, UUID origNodeId) {

/** {@inheritDoc} */
@Nullable @Override public DiscoveryCustomMessage ackMessage() {
return !rejected ? new MetadataRemoveAcceptedMessage(typeId) : null;
return !rejected() ? new MetadataRemoveAcceptedMessage(typeId) : null;
}

/** {@inheritDoc} */
Expand All @@ -95,13 +91,12 @@ public MetadataRemoveProposedMessage(int typeId, UUID origNodeId) {
* @param errMsg Error message caused this update to be rejected.
*/
void markRejected(String errMsg) {
rejected = true;
this.errMsg = errMsg;
}

/** */
boolean rejected() {
return rejected;
return errMsg != null;
}

/** */
Expand Down Expand Up @@ -133,5 +128,4 @@ public void setOnCoordinator(boolean onCoordinator) {
@Override public String toString() {
return S.toString(MetadataRemoveProposedMessage.class, this);
}

}
Loading