-
Notifications
You must be signed in to change notification settings - Fork 920
Support for PHP 8.5 pipe operator #9113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
f4dc655
8e44011
052f4c3
fbaeb2e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -41,6 +41,7 @@ | |||||
| "PhpVersion.PHP_82=PHP 8.2", | ||||||
| "PhpVersion.PHP_83=PHP 8.3", | ||||||
| "PhpVersion.PHP_84=PHP 8.4", | ||||||
| "PhpVersion.PHP_85=PHP 8.5", | ||||||
| }) | ||||||
| public enum PhpVersion { | ||||||
|
|
||||||
|
|
@@ -115,6 +116,11 @@ public enum PhpVersion { | |||||
| * @since 2.100 | ||||||
| */ | ||||||
| PHP_84(Bundle.PhpVersion_PHP_84()), | ||||||
| /** | ||||||
| * PHP 8.4. | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| * @since 2.x | ||||||
| */ | ||||||
| PHP_85(Bundle.PhpVersion_PHP_85()), | ||||||
| ; | ||||||
|
|
||||||
| private final String displayName; | ||||||
|
|
@@ -373,6 +379,7 @@ private enum Period { | |||||
| PHP_82(LocalDate.of(2022, 12, 8), LocalDate.of(2024, 12, 31), LocalDate.of(2026, 12, 31)), | ||||||
| PHP_83(LocalDate.of(2023, 11, 23), LocalDate.of(2025, 12, 31), LocalDate.of(2027, 12, 31)), | ||||||
| PHP_84(LocalDate.of(2024, 11, 21), LocalDate.of(2026, 12, 31), LocalDate.of(2028, 12, 31)), | ||||||
| PHP_85(LocalDate.of(2025, 11, 20), LocalDate.of(2027, 12, 31), LocalDate.of(2029, 12, 31)), | ||||||
| ; | ||||||
|
|
||||||
| private final LocalDate initialRelease; | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -343,6 +343,13 @@ && isFirstCommaAfterDoubleArrow(startExpression, caretOffset, ts)) { | |
| newIndent = Utilities.getRowIndent(doc, startExpression) + continuationSize; | ||
| break; | ||
| } | ||
| } else if (ts.token().id() == PHPTokenId.PHP_OPERATOR && TokenUtilities.textEquals("|>", ts.token().text())) { // NOI18N | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just curious - don't we use constants for these PHP operators? |
||
| //PHP 8.5 align pipe operator chain expressions | ||
| int startExpression = LexUtilities.findStartTokenOfExpression(ts); | ||
| if (startExpression != -1) { | ||
| newIndent = Utilities.getRowIndent(doc, startExpression); | ||
| break; | ||
| } | ||
| } | ||
| } | ||
| previousTokenId = ts.token().id(); | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An API class is changed -> we need to increase the version of this API module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(And this new version muist be used by other modules.)