HDDS-14533. Include filesystem metrics in storage Distribution endpoint#9700
HDDS-14533. Include filesystem metrics in storage Distribution endpoint#9700devmadhuu merged 3 commits intoapache:masterfrom
Conversation
siddhantsangwan
left a comment
siddhantsangwan
left a comment
There was a problem hiding this comment.
Does the Recon frontend show data from the storage distribution endpoint yet? If yes, it's worth checking whether Recon is showing the new fs stats correctly.
| assertEquals(report.getRemaining(), scmReport.getRemaining()); | ||
| assertEquals(report.getUsed(), scmReport.getUsed()); | ||
| assertEquals(report.getCommitted(), scmReport.getCommitted()); | ||
| assertEquals(report.getFilesystemAvailable(), scmReport.getFsAvailable()); |
There was a problem hiding this comment.
Nitpick for future pull requests: Since scmReport is the correct expected value, it should be the first argument in assertEquals.
|
@siddhantsangwan Thanks for the review
Currently these information is not used in Capacity page. It will included in the UI as part of https://issues.apache.org/jira/browse/HDDS-14552 |
siddhantsangwan
left a comment
siddhantsangwan
left a comment
There was a problem hiding this comment.
LGTM, pending CI.
devmadhuu
left a comment
devmadhuu
left a comment
There was a problem hiding this comment.
Thanks @priyeshkaratha for the patch. LGTM +1
|
Thank you @siddhantsangwan for the review and thanks @priyeshkaratha for the patch. |
3 participants
What changes were proposed in this pull request?
This pull request enhances the StorageDistributionEndpoint by incorporating detailed filesystem usage metrics, including capacity, available, and used space, into the datanode storage reports. Current report gives zero values.
Filesystem Metrics Integration: This pull request integrates filesystem-level capacity, available, and used space metrics into the DatanodeStorageReport object, providing a more granular view of storage.
Storage Distribution Endpoint Enhancement: The StorageDistributionEndpoint has been updated to retrieve and include these new filesystem metrics when generating storage reports for individual datanodes.
What is the link to the Apache JIRA
HDDS-14533
How was this patch tested?
Tested with updated integration tests.