Skip to content

[ISSUE #10165] Prevent RocksDB metrics from being overwritten after timer engine switch#10166

Merged
lizhimins merged 4 commits intoapache:developfrom
3424672656:fix_timer_metrics
Mar 30, 2026
Merged

[ISSUE #10165] Prevent RocksDB metrics from being overwritten after timer engine switch#10166
lizhimins merged 4 commits intoapache:developfrom
3424672656:fix_timer_metrics

Conversation

@3424672656
Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.92%. Comparing base (e100743) to head (a6b076f).

Files with missing lines Patch % Lines
...apache/rocketmq/store/timer/TimerMessageStore.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10166      +/-   ##
=============================================
- Coverage      48.93%   48.92%   -0.01%     
+ Complexity     13384    13376       -8     
=============================================
  Files           1373     1373              
  Lines          99924    99926       +2     
  Branches       12908    12909       +1     
=============================================
- Hits           48898    48890       -8     
+ Misses         45098    45078      -20     
- Partials        5928     5958      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins lizhimins changed the title [ISSUE #10165] Fix checkAndReviseMetrics overwriting RocksDB metrics after timer engine switch [ISSUE #10165] Prevent RocksDB metrics from being overwritten after timer engine switch Mar 30, 2026
@lizhimins lizhimins merged commit d66cfa9 into apache:develop Mar 30, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]Fix checkAndReviseMetrics overwriting RocksDB metrics after timer engine switch

3 participants