[ISSUE #10173] Support LMQ in CombineConsumeQueueStore without migration to RocksDB CQ#10174
Merged
lizhimins merged 2 commits intoapache:developfrom Apr 3, 2026
Merged
[ISSUE #10173] Support LMQ in CombineConsumeQueueStore without migration to RocksDB CQ#10174lizhimins merged 2 commits intoapache:developfrom
lizhimins merged 2 commits intoapache:developfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #10174 +/- ##
=============================================
+ Coverage 48.94% 49.27% +0.33%
- Complexity 13389 13707 +318
=============================================
Files 1373 1373
Lines 99924 101930 +2006
Branches 12908 13539 +631
=============================================
+ Hits 48904 50225 +1321
- Misses 45097 45705 +608
- Partials 5923 6000 +77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lizhimins
reviewed
Apr 3, 2026
| } | ||
|
|
||
| public static String getStorePathRocksDBConsumeQueue(final String rootDir) { | ||
| return rootDir + File.separator + "consumequeue_r"; |
Contributor
Author
There was a problem hiding this comment.
'consumequeue_rocksdb' would be better.
lizhimins
reviewed
Apr 3, 2026
| checkFile = new File(StorePathConfigHelper.getStorePathConsumeQueue(root) + File.separator + "CURRENT"); | ||
| } else { | ||
| this.storePath = StorePathConfigHelper.getStorePathConsumeQueue(root); | ||
| checkFile = new File(StorePathConfigHelper.getStorePathRocksDBConsumeQueue(root) + File.separator + "CURRENT"); |
Member
There was a problem hiding this comment.
Is the current file used to determine whether it has been created?
lizhimins
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10173