Enable to disable request/error counters and cache stats#576
Open
rmannibucau wants to merge 1 commit intoapache:mainfrom
Open
Enable to disable request/error counters and cache stats#576rmannibucau wants to merge 1 commit intoapache:mainfrom
rmannibucau wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
This seems like a lot of code to avoid two addition operations. What's the use-case, here? |
Contributor
Author
|
@ChristopherSchultz mainly reduce the associated overhead (cpu - cas - and mem - in no luck case multiple cells are allocated per context) since most of the time these counters are useless as such - it is not rare to either not use them at all or duplicate them in a monitoring solution. In terms of code it is only ~30LoC, rest is the enablement of the counters. Agree it is not critical - why I didnt push it much more, but it is overall weird to enable by default such things and has a cost and is not easy to drop since it is in this particular valve - it would be another it could be dropped, wich can be a better option maybe? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.