[ZEPPELIN-6400] Remove ZeppelinConfiguration dependency from zeppelin-interpreter module#5167
Draft
[ZEPPELIN-6400] Remove ZeppelinConfiguration dependency from zeppelin-interpreter module#5167
Conversation
…-interpreter module Move ZeppelinConfiguration to zeppelin-zengine so it is no longer included in the shaded interpreter JAR. This prevents the Maven shade plugin from corrupting config string literals, which caused classpath- order-dependent configuration loading failures. Key changes: - Replace ZeppelinConfiguration usage in zeppelin-interpreter with Properties-based configuration - Update InterpreterLauncher, LifecycleManager, RecoveryStorage, DependencyResolver to accept Properties instead of ZeppelinConfiguration - Update all launcher plugins (Docker, K8s, YARN, Flink) accordingly - Move ZeppelinConfiguration.java and ZeppelinLocationStrategy.java from zeppelin-interpreter to zeppelin-zengine - Update callers in zeppelin-zengine, zeppelin-server, flink, and markdown interpreters Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
FlexmarkParser now accepts Properties for better extensibility, instead of a single boolean escapeHtml parameter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…onnectTimeout ZeppelinConfiguration parsed time values like "600s" internally, but after switching to Properties, the raw string is passed directly. Add parseTimeValue() to handle "s" (seconds) and "ms" (milliseconds) suffixes in timeout configuration values. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…zengine Move server-side-only classes (InterpreterLauncher, InterpreterClient, InterpreterLaunchContext, RecoveryStorage, InterpreterLauncherTest) from zeppelin-interpreter to zeppelin-zengine. This allows launcher plugins and recovery storage to keep using ZeppelinConfiguration directly, eliminating unnecessary Properties conversion code. Reverts launcher plugins and zengine launcher/recovery files to their original ZeppelinConfiguration-based implementations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ZeppelinConfigurationfromzeppelin-interpretertozeppelin-zengineso it is no longer included in the shaded interpreter JAR. This prevents the Maven shade plugin from corrupting config string literals, which caused classpath-order-dependent configuration loading failures.ZeppelinConfigurationusage inzeppelin-interpreterwithProperties-based configuration acrossInterpreterLauncher,LifecycleManager,RecoveryStorage,DependencyResolver, and all launcher plugins (Docker, K8s, YARN, Flink).zeppelin-zengine,zeppelin-server,flink, andmarkdowninterpreter modules.Motivation
ZeppelinConfigurationinzeppelin-interpretergets processed by the Maven shade plugin, which corrupts string literals (e.g.,org.apache.zeppelin→unshaded.org.apache.zeppelin). This causes config keys to mismatch at runtime depending on classpath ordering. Moving it tozeppelin-zengine(which is not shaded) permanently eliminates this class of bugs.As discussed by the community: "ZeppelinConfiguration belongs to the Zeppelin server, and the Zeppelin interpreter should really only work on a HashMap with ConfigKey and ConfigValue."
Changes
zeppelin-interpreter(core)ZeppelinConfigurationimports; usePropertiesfor configInterpreterLauncherZeppelinConfiguration zConf→Properties zPropertiesLifecycleManager/RecoveryStoragePropertiesinstead ofZeppelinConfigurationDependencyResolverZeppelinConfigurationProperties-based APIzeppelin-zenginePluginManagerpasses derived values (absolute paths) via PropertiesZeppelinConfiguration.javazeppelin-interpreter→zeppelin-zengine50 files changed, +320 −1591 lines (net reduction ~1271 lines)
Test Plan
core.yml- Core module testscore.yml- Interpreter tests (Spark, Flink)frontend.yml- E2E testsquick.yml- RAT license checkZeppelinConfiguration