Open
Conversation
eldadfux
requested changes
Mar 6, 2023
2 tasks
eldadfux
approved these changes
Mar 8, 2023
lohanidamodar
commented
Mar 9, 2023
lohanidamodar
commented
Mar 13, 2023
| **PATCH /v1/projects/:projectId/template/sms/:type/:locale** - updates custom SMS templates | ||
|
|
||
| - **type** : string - required - template type | ||
| - **locale** : string - required (eg: en_us) - locale of the template |
Member
Author
There was a problem hiding this comment.
@eldadfux I'm having problem with the full locale en_us our locale library only accepts en. What's the purpose of having this full?
Member
There was a problem hiding this comment.
There are differences between en_us and en_uk, some might want to be more accurate.
|
It would be awesome to have this merged, moreover would be even better to have it available in AW Cloud in order to send the emails from the project's domain instead of the global [email protected] |
|
@eldadfux can you merge this now or is there something else left to do? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
RFC for
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)