Skip to content

Update button href to point to new endpoint#2849

Merged
HarshMN2345 merged 4 commits intomainfrom
HarshMN2345-patch-2
Apr 5, 2026
Merged

Update button href to point to new endpoint#2849
HarshMN2345 merged 4 commits intomainfrom
HarshMN2345-patch-2

Conversation

@HarshMN2345
Copy link
Copy Markdown
Member

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 2, 2026

Greptile Summary

This PR changes the "View full benchmark" button's href from the dynamic {VARS.ARENA_ENDPOINT} environment variable to the hardcoded URL https://arena.appwrite.io. While the intent appears to be updating the link to point to a new endpoint, the change introduces an inconsistency between the button's destination and the backend API used to fetch benchmark data.

  • The button now hardcodes https://arena.appwrite.io as its destination
  • The arena API endpoint (/src/routes/api/arena/+server.ts) still fetches data from VARS.ARENA_ENDPOINT with a fallback of https://arena.appwrite.network — a different domain
  • The .env.example still documents PUBLIC_ARENA_ENDPOINT=https://arena.appwrite.network
  • The hardcoded value bypasses the PUBLIC_ARENA_ENDPOINT environment variable, removing the ability to configure per-environment (staging vs. production)
  • The PR description does not explain the motivation or which domain is authoritative

Confidence Score: 3/5

Not safe to merge as-is — the button destination and the benchmark data source now point to different domains, and the env-var configurability is broken.

A P1 finding is present: the hardcoded URL diverges from the domain used by the companion API endpoint and the documented env var default, meaning users clicking the button may see inconsistent data vs. what the table shows. The PR description is also empty, making it impossible to confirm which domain is authoritative.

src/routes/(marketing)/(components)/ai-table.svelte — also review src/routes/api/arena/+server.ts and .env.example for alignment

Important Files Changed

Filename Overview
src/routes/(marketing)/(components)/ai-table.svelte Button href changed from dynamic VARS.ARENA_ENDPOINT to hardcoded https://arena.appwrite.io, creating a domain mismatch with the API data source (arena.appwrite.network) and breaking per-environment configurability

Comments Outside Diff (1)

  1. src/routes/(marketing)/(components)/ai-table.svelte, line 191 (link)

    Domain mismatch with API data source

    The button now points to https://arena.appwrite.io, but the server-side API route (src/routes/api/arena/+server.ts) that populates the benchmark table still fetches data from VARS.ARENA_ENDPOINT with a hardcoded fallback of https://arena.appwrite.network — a different domain. This means the data displayed in the table and the destination users land on when clicking "View full benchmark" may come from two different sources.

    If the intent is to migrate to arena.appwrite.io, the fallback URL in +server.ts, the .env.example value, and the CI/CD environment variables should also be updated.

    Additionally, by hardcoding the URL here instead of continuing to use {VARS.ARENA_ENDPOINT}, the link can no longer be configured differently across environments (staging, production), which was previously possible via the PUBLIC_ARENA_ENDPOINT env var.

Greploops — Automatically fix all review issues by running /greploops in Claude Code. It iterates: fix, push, re-review, repeat until 5/5 confidence.
Use the Greptile plugin for Claude Code to query reviews, search comments, and manage custom context directly from your terminal.

Reviews (3): Last reviewed commit: "format" | Re-trigger Greptile

@HarshMN2345 HarshMN2345 merged commit 183de22 into main Apr 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants