Skip to content

docs: document first-session exception in session alerts#2897

Merged
Meldiron merged 3 commits intomainfrom
copilot/document-no-email-first-sign-in
Apr 17, 2026
Merged

docs: document first-session exception in session alerts#2897
Meldiron merged 3 commits intomainfrom
copilot/document-no-email-first-sign-in

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 17, 2026

  • Locate all documentation for the session alerts feature
  • Update auth-security.md to clearly document that the first session (sign-in immediately after sign-up) does not trigger a session alert email, with an explanation of why
  • Rephrase first-session rationale: remove "proven they own their email address" (not true for email+password), replace with "new account doesn't yet hold anything worthy of protection"

Comment thread src/partials/auth-security.md Outdated
Copilot AI requested a review from Meldiron April 17, 2026 10:11
Comment thread src/partials/auth-security.md
Copy link
Copy Markdown
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Meldiron Meldiron marked this pull request as ready for review April 17, 2026 10:13
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 17, 2026

Greptile Summary

This PR adds a well-structured "When alerts are not sent" subsection to the session alerts documentation, covering the first-session exception, auth methods that skip alerts, and accounts without an email address. The rationale for the first-session case is accurate and clearly explained.

Confidence Score: 5/5

Safe to merge; only a minor heading-level style note remains.

All findings are P2 style suggestions. The content is accurate and clearly improves the existing documentation.

No files require special attention.

Important Files Changed

Filename Overview
src/partials/auth-security.md Documents first-session and other alert exceptions clearly; introduces the only H2 heading in a doc that otherwise uses exclusively H1 headings

Reviews (2): Last reviewed commit: "Update src/partials/auth-security.md" | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

@adityaoberai adityaoberai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Meldiron I have only one suggestion, approving PR to unblock merge

Comment thread src/partials/auth-security.md Outdated
Co-authored-by: Aditya Oberai <adityaoberai1@gmail.com>
@Meldiron Meldiron merged commit cbff21d into main Apr 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants