Automatically fetch latest ruby-build version with 24h cache#484
Open
exterm wants to merge 2 commits intoasdf-vm:masterfrom
Open
Automatically fetch latest ruby-build version with 24h cache#484exterm wants to merge 2 commits intoasdf-vm:masterfrom
exterm wants to merge 2 commits intoasdf-vm:masterfrom
Conversation
bca5f07 to
c27f94c
Compare
Contributor
Author
|
I was so unsure about the cache that I added a commit to remove it. We can merge this with or without cache. Maintainer's choice @Stratus3D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetches the newest ruby-build version whenever ruby-build is used, with a 24 hour cache.
I wasn't sure about the cache, but it seems wasteful to fetch the newest version every time.
Fixes #464