Use definitions from stdint.h instead define uintXX_t by hand#224
Closed
ziyao233 wants to merge 1 commit intoasg017:mainfrom
Closed
Use definitions from stdint.h instead define uintXX_t by hand#224ziyao233 wants to merge 1 commit intoasg017:mainfrom
ziyao233 wants to merge 1 commit intoasg017:mainfrom
Conversation
Author
|
I originally intended to test the change in CI of my local repository and this PR is opened by mistake, Will polish my change and mark the PR ready for review when it's really done. Sorry for the noise. |
These hand-written definitions don't compile on some platforms like musl since u_intXX_t (with two underscores) types aren't standard. As stdint.h already contains defintions for uintXX_t types, there's no reason to define them manually. Let's clean them up. Signed-off-by: Yao Zi <[email protected]>
ziyao233
force-pushed
the
musl/fix-u_intxx_t-definition
branch
from
6ef31d4 to
8d7daeb
Compare
ziyao233
changed the title
Author
|
Oops, it's a duplication of #219. I'm closing it. Really sorry for the inconvenience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.