Fix OrchardCore Net8.0 and Net9.0 baseline runs#2147
Fix OrchardCore Net8.0 and Net9.0 baseline runs#2147LoopedBard3 merged 2 commits intoaspnet:mainfrom
Conversation
…nch, the latest branch that supports building for net8 and net9.
….branchOrCommit and update net9.0 to run the last commit before migration to net10 from main.
There was a problem hiding this comment.
Pull request overview
This PR updates the OrchardCore baseline benchmark configuration to use framework-specific branches that support building for .NET 8.0 and 9.0. The original configuration was likely using incompatible branch/commit references for these framework versions.
Changes:
- Split OrchardCore configuration into separate baseline and scenario parameters to use framework-specific branches
- Added dedicated
orchardBaselinesparameter with different branch references for net8.0 (release/2.2) and net9.0 (main commit hash) - Created separate execution steps for Orchard scenarios to utilize the new Orchard-specific baselines
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - displayName: "10.0" | ||
| arguments: --application.framework net10.0 --property framework=net10.0 --application.noGlobalJson false | ||
|
|
||
| # Orchard Baselines (uses release/2.2 branch for net8.0 and main#eefd4a1659cd48e56b681b5bcff2cc92b349b464 for net9.0) |
There was a problem hiding this comment.
The comment incorrectly states that net8.0 uses release/2.2 and net9.0 uses the main commit hash, but looking at the actual configuration, both net8.0 (line 40) uses release/2.2 and net9.0 (line 43) uses the main commit hash. The comment should clarify that net10.0 continues to use the default branch behavior without a specific branchOrCommit override.
| # Orchard Baselines (uses release/2.2 branch for net8.0 and main#eefd4a1659cd48e56b681b5bcff2cc92b349b464 for net9.0) | |
| # Orchard Baselines (net8.0 uses release/2.2, net9.0 uses main#eefd4a1659cd48e56b681b5bcff2cc92b349b464, and net10.0 uses the default branch without a branchOrCommit override) |
|
Looks food, were you able to test it? |
|
Here is a successful test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2893979&view=results (Just the Orchard Core runs). |
Update OrchardCore net8 and net9 baseline runs to use release/2.2 branch, the latest branch that supports building for net8 and net9. Verified for both net8 and net9 locally. Different branchOrCommit options are being used for net8.0 and net9.0 as neither of the 2 selected were compatible with both.