Skip to content

Fix OrchardCore Net8.0 and Net9.0 baseline runs#2147

Merged
LoopedBard3 merged 2 commits intoaspnet:mainfrom
LoopedBard3:FixOrchardNet8And9TestRuns
Feb 3, 2026
Merged

Fix OrchardCore Net8.0 and Net9.0 baseline runs#2147
LoopedBard3 merged 2 commits intoaspnet:mainfrom
LoopedBard3:FixOrchardNet8And9TestRuns

Conversation

@LoopedBard3
Copy link
Contributor

Update OrchardCore net8 and net9 baseline runs to use release/2.2 branch, the latest branch that supports building for net8 and net9. Verified for both net8 and net9 locally. Different branchOrCommit options are being used for net8.0 and net9.0 as neither of the 2 selected were compatible with both.

…nch, the latest branch that supports building for net8 and net9.
….branchOrCommit and update net9.0 to run the last commit before migration to net10 from main.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the OrchardCore baseline benchmark configuration to use framework-specific branches that support building for .NET 8.0 and 9.0. The original configuration was likely using incompatible branch/commit references for these framework versions.

Changes:

  • Split OrchardCore configuration into separate baseline and scenario parameters to use framework-specific branches
  • Added dedicated orchardBaselines parameter with different branch references for net8.0 (release/2.2) and net9.0 (main commit hash)
  • Created separate execution steps for Orchard scenarios to utilize the new Orchard-specific baselines

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- displayName: "10.0"
arguments: --application.framework net10.0 --property framework=net10.0 --application.noGlobalJson false

# Orchard Baselines (uses release/2.2 branch for net8.0 and main#eefd4a1659cd48e56b681b5bcff2cc92b349b464 for net9.0)
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment incorrectly states that net8.0 uses release/2.2 and net9.0 uses the main commit hash, but looking at the actual configuration, both net8.0 (line 40) uses release/2.2 and net9.0 (line 43) uses the main commit hash. The comment should clarify that net10.0 continues to use the default branch behavior without a specific branchOrCommit override.

Suggested change
# Orchard Baselines (uses release/2.2 branch for net8.0 and main#eefd4a1659cd48e56b681b5bcff2cc92b349b464 for net9.0)
# Orchard Baselines (net8.0 uses release/2.2, net9.0 uses main#eefd4a1659cd48e56b681b5bcff2cc92b349b464, and net10.0 uses the default branch without a branchOrCommit override)

Copilot uses AI. Check for mistakes.
@sebastienros
Copy link
Member

Looks food, were you able to test it?

@LoopedBard3
Copy link
Contributor Author

Here is a successful test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2893979&view=results (Just the Orchard Core runs).

@LoopedBard3 LoopedBard3 merged commit 7ccf4c9 into aspnet:main Feb 3, 2026
2 of 3 checks passed
@LoopedBard3 LoopedBard3 deleted the FixOrchardNet8And9TestRuns branch February 3, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants