Conversation
There was a problem hiding this comment.
Pull Request Overview
Removes the deprecated dotnet-core feed and adds two Azure DevOps feeds for package restore.
- Replace the old dotnet-core URL with the
dotnet-engfeed - Add the
myget-legacyfeed alongside the existing public feed
Comments suppressed due to low confidence (1)
build/sources.props:8
- [nitpick] There are no tests or validation steps to ensure that the updated restore sources are applied correctly; consider adding an integration test or build verification to catch misconfigurations.
https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json;
| <RestoreSources Condition="'$(DotNetBuildOffline)' != 'true'"> | ||
| $(RestoreSources); | ||
| https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json; | ||
| https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json; |
There was a problem hiding this comment.
[nitpick] Consider updating any relevant project documentation or README to reflect the new restore sources so team members are aware of the added feeds.
Comment on lines
6
to
+10
| <RestoreSources Condition="'$(DotNetBuildOffline)' != 'true'"> | ||
| $(RestoreSources); | ||
| https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json; | ||
| https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json; | ||
| https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json; | ||
| https://pkgs.dev.azure.com/dnceng/public/_packaging/myget-legacy/nuget/v3/index.json; |
There was a problem hiding this comment.
[nitpick] Hardcoding these URLs may complicate future updates; consider extracting feed URLs into a named MSBuild property for easier reuse and maintenance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.