Add validation for completer jmespaths #9992
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the protocol test `test_completion_files.py` to also verify that all jmespaths in the completers correspond with the model. Also checks that the resulting field is a string, so that autocompletion works correctly. Additionally, removed 306 resource ids and their completions across 53 services. Previously, nearly all of them, if used, would throw an error; the exceptions are a few in CloudFormation which failed silently. If the completions are desired, they can be added back later, but in their current form, they don't work.
Contributor
|
Thanks @Songblade! This is gonna take me a while to spot check, but in the meantime can you add a changelog entry? You can create one by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Modified the functional test
test_completion_files.pyto also verify that all jmespaths in the completers correspond with the model. Also checks that the resulting field is a string, so that autocompletion works correctly.Additionally, removed 306 resource ids and their completions across 53 services. Previously, nearly all of them, if used, would throw an error; the exceptions are a few in CloudFormation which failed silently. If the completions are desired, they can be added back later, but in their current form, they don't work.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.