fix: auto setup after install is broken, let user run it manually#131
Open
dheerapat wants to merge 1 commit intobasecamp:masterfrom
Open
fix: auto setup after install is broken, let user run it manually#131dheerapat wants to merge 1 commit intobasecamp:masterfrom
dheerapat wants to merge 1 commit intobasecamp:masterfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a broken post-install flow in scripts/install.sh by removing the automatic fizzy setup run (which previously executed from a temporary working directory and caused the generated config to be deleted on script exit). Users are now instructed to run setup manually after installation.
Changes:
- Remove the post-install auto-run of
fizzy setup. - Print a clear instruction for the user to run
fizzy setupmanually after installation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove autorun
fizzy setupafter installation (current config file save on the wrong place), instruct user to run it manually.Why
detail on #130
Testing
make checkpassesSummary by cubic
Stop auto-running
fizzy setupafter install and show a prompt to run it manually. This prevents writing the config to the wrong location and avoids a broken post-install step.setupinvocation inscripts/install.sh; now only prints “Run '$INSTALL_DIR/${BINARY} setup' to get started.”Written for commit 6cb6a27. Summary will update on new commits.