refactor: remove create_executable_result_struct helper

[rickeylev]

The create_executable_result_struct_helper is a remnant of the semantics apis, which
are no longer needed.

[gemini-code-assist]

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a refactoring by eliminating an obsolete helper function, create_executable_result_struct, which was associated with deprecated semantics APIs. The functionality previously provided by this helper is now directly integrated at its point of use, streamlining the code and removing an unnecessary layer of abstraction.

Highlights

• Helper Function Removal: The create_executable_result_struct helper function has been entirely removed from python/private/common.bzl as it was a remnant of no longer needed semantics APIs.
• Inlining Logic: The logic previously encapsulated by create_executable_result_struct has been inlined directly into the _create_executable function within python/private/py_executable.bzl, replacing the helper function call with a direct struct instantiation.
• Import Clean-up: The import statement for create_executable_result_struct has been removed from python/private/py_executable.bzl to reflect its removal.
• Code Clarity: Comments have been added to the inlined struct creation in python/private/py_executable.bzl to explicitly describe the purpose of each argument, enhancing readability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a good refactoring that removes the create_executable_result_struct helper function. The change is straightforward and correctly replaces the helper function call with a direct struct creation, improving code clarity by removing an unnecessary layer of abstraction. The addition of inline comments at the call site effectively documents the fields of the anonymous struct, maintaining readability. The changes are clean and I have no suggestions for improvement.

[aignas]

What else is left for #2522?

[rickeylev]

The "create native cc lib" code is the last major thing. There are probably also some helper functions like this sitting around in what are now weird places.

[rickeylev]

Ah, this got subsumed by #3542, closing this PR