Skip to content

chore: remove testing of Bazel 7 #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rickeylev wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −17
Open

chore: remove testing of Bazel 7 #3541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .bazelci/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ buildifier:
# Use a specific version to avoid skew issues when new versions are released.
version: 8.2.1
warnings: "all"
# NOTE: Minimum supported version is 7.x
# NOTE: Minimum supported version is 8.x
.minimum_supported_version: &minimum_supported_version
# For testing minimum supported version.
# NOTE: Keep in sync with //:version.bzl
bazel: 7.x
skip_in_bazel_downstream_pipeline: "Bazel 7 required"
bazel: 8.x
skip_in_bazel_downstream_pipeline: "Bazel 8 required"
.reusable_config: &reusable_config
build_targets:
- "--"
Expand Down Expand Up @@ -56,7 +56,7 @@ buildifier:
- "--noenable_bzlmod"
- "--enable_workspace"
- "--build_tag_filters=-integration-test"
bazel: 7.x
bazel: 8.x
# NOTE: The Mac and Windows bazelinbazel jobs override parts of this config.
.common_bazelinbazel_config: &common_bazelinbazel_config
build_flags:
Expand Down Expand Up @@ -117,7 +117,7 @@ matrix:
- debian11
- macos_arm64
- windows
bazel: [7.*, 8.*, 9.*]
bazel: [8.*, 9.*]

tasks:
# Keep in sync with .bcr/presubmit.yml
Expand Down Expand Up @@ -183,7 +183,7 @@ tasks:
<<: *reusable_config
name: "Default: Ubuntu, bzlmod, minimum Bazel"
platform: ubuntu2204
bazel: 7.x
bazel: 8.x
ubuntu:
<<: *reusable_config
name: "Default: Ubuntu"
Expand Down Expand Up @@ -282,7 +282,7 @@ tasks:
platform: rbe_ubuntu2204
# TODO @aignas 2024-12-11: get the RBE working in CI for bazel 8.0
# See https://github.com/bazelbuild/rules_python/issues/2499
bazel: 7.x
bazel: 8.x
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The Bazel version is updated to 8.x, but the comment on the preceding lines (283-284) mentions a known issue with Bazel 8.0 on RBE. Has this issue been resolved? If so, it would be good practice to also remove the TODO comment to avoid confusion. If the issue is still present, this change might cause CI failures.

test_flags:
- "--test_tag_filters=-integration-test,-acceptance-test"
- "--extra_toolchains=@buildkite_config//config:cc-toolchain"
Expand Down Expand Up @@ -371,7 +371,7 @@ tasks:
name: "examples/pip_parse: Ubuntu, bzlmod, minimum supported Bazel version"
working_directory: examples/pip_parse
platform: ubuntu2204
bazel: 7.x
bazel: 8.x
integration_test_pip_parse_ubuntu:
<<: *reusable_build_test_all
name: "examples/pip_parse: Ubuntu"
Expand Down Expand Up @@ -587,7 +587,7 @@ tasks:
name: "compile_pip_requirements_test_from_external_repo: Ubuntu, bzlmod, minimum Bazel"
working_directory: tests/integration/compile_pip_requirements_test_from_external_repo
platform: ubuntu2204
bazel: 7.x
bazel: 8.x
shell_commands:
# Assert that @compile_pip_requirements//:requirements_test does the right thing.
- "bazel test @compile_pip_requirements//..."
Expand Down
2 changes: 0 additions & 2 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,6 @@ bazel_binaries.local(
name = "self",
path = "tests/integration/bazel_from_env",
)
bazel_binaries.download(version = "7.4.1")
bazel_binaries.download(version = "8.0.0")
bazel_binaries.download(version = "9.0.0rc1")
use_repo(
Expand All @@ -365,7 +364,6 @@ use_repo(
# These don't appear necessary, but are reported as direct dependencies
# that should be use_repo()'d, so we add them as requested
"bazel_binaries_bazelisk",
"build_bazel_bazel_7_4_1",
"build_bazel_bazel_8_0_0",
"build_bazel_bazel_9_0_0rc1",
# "build_bazel_bazel_rolling",
Expand Down
1 change: 0 additions & 1 deletion tests/integration/compile_pip_requirements/.bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@ test --test_output=errors

# Windows requires these for multi-python support:
build --enable_runfiles
common:bazel7.x --incompatible_python_disallow_native_rules
1 change: 0 additions & 1 deletion tests/integration/compile_pip_requirements_test_from_external_repo/.bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
test --test_output=errors
common:bazel7.x --incompatible_python_disallow_native_rules
1 change: 0 additions & 1 deletion tests/integration/local_toolchains/.bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@ common --lockfile_mode=off
test --test_output=errors
# Windows requires these for multi-python support:
build --enable_runfiles
common:bazel7.x --incompatible_python_disallow_native_rules
build --//:py=local
common --announce_rc
2 changes: 0 additions & 2 deletions tests/integration/pip_parse/.bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,3 @@ build --enable_runfiles

# https://docs.bazel.build/versions/main/best-practices.html#using-the-bazelrc-file
try-import %workspace%/user.bazelrc

common:bazel7.x --incompatible_python_disallow_native_rules
1 change: 0 additions & 1 deletion tests/integration/py_cc_toolchain_registered/.bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
# This aids debugging on failure
build --toolchain_resolution_debug=python
common:bazel7.x --incompatible_python_disallow_native_rules
Loading