Fix generated manifest package name formatting#448
Closed
argahutama wants to merge 1 commit intobazelbuild:mainfrom
Closed
Fix generated manifest package name formatting#448argahutama wants to merge 1 commit intobazelbuild:mainfrom
argahutama wants to merge 1 commit intobazelbuild:mainfrom
Conversation
argahutama
force-pushed
the
fix/generated_manifest_package_name
branch
from
d0161ca to
800a751
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix invalid Android package name generation when the Bazel package contains hyphens.
Hyphens (-) are not valid in Java package names, so we now replace them with dots (.) when generating the dummy manifest to prevent build errors and invalid manifests.
#445