Skip to content

Business API/model - liquidation report updates#4138

Merged
kialj876 merged 3 commits intobcgov:mainfrom
kialj876:32568-liquidation-report-updates
Mar 6, 2026
Merged

Business API/model - liquidation report updates#4138
kialj876 merged 3 commits intobcgov:mainfrom
kialj876:32568-liquidation-report-updates

Conversation

@kialj876
Copy link
Collaborator

@kialj876 kialj876 commented Mar 5, 2026

Issue #: /bcgov/entity#32568

Description of changes:

  • liquidation report updates
  • other liquidation updates
  • prta display name change

NOTE: will have a subsequent PR for email-reminder, dissolution-service and the business-filer after this is merged

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
@kialj876
Copy link
Collaborator Author

kialj876 commented Mar 5, 2026

Quality Gate Failed Quality Gate failed

Failed conditions 12.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

duplication is from the common model vs lear api code

Signed-off-by: Kial Jinnah <kialj876@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
13.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@kialj876
Copy link
Collaborator Author

kialj876 commented Mar 6, 2026

Quality Gate Failed Quality Gate failed

Failed conditions 13.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

duplication is from the common model vs lear api code

@kialj876 kialj876 merged commit 099fae6 into bcgov:main Mar 6, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants