feat: add BIP353 DNS payment instructions

[sdmg15]

Description

This PR adds support for BIP353 payment instructions.
The following notable changes are done:

• Adding of an option resolve_dns_recipient which receives a Human Readable Name (HRN) and returns the associated address
• Modify the create_tx for it to support user specifying recipients as HRN.

Notes to the reviewers

Here is a list of HRN that could be used to test the implementation:

• pay@dunxen.dev: Supports BOLT 12 Payment method only
• send.some@satsto.me: Supports BOLT 12 payment and On Chain
• Testing resolving: bdk-cli -n bitcoin resolve_dns_recipient send.some@satsto.me
• Testing create tx: bdk-cli -n bitcoin wallet -w regtest_default_wallet create_tx --to "bcrt1qe497k549sgw9trzym50tdlegq3xx4apjqynjqm:1000" --to_dns "send.some@satsto.me:5000"

Changelog notice

• Add top level command resolve_dns_recipient to resolve the DNS payment instructions
• Add option --to_dns to create_tx command to allow sending to a Human Readable Name (HRN)

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

New Features:

• I've added tests for the new feature
• I've added docs for the new feature
• I've updated CHANGELOG.md

[va-an]

@sdmg15 Hi! Could you make it compile?

[coveralls]

Pull Request Test Coverage Report for Build 21818410493

Details

• 0 of 120 (0.0%) changed or added relevant lines in 3 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.5%) to 10.237%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/utils.rs	0	15	0.0%
src/handlers.rs	0	36	0.0%
src/dns_payment_instructions.rs	0	69	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/handlers.rs	1	12.57%

Totals
Change from base Build 21153868360:	-0.5%
Covered Lines:	268
Relevant Lines:	2618

---

💛 - Coveralls

[sdmg15]

@va-an Thanks for taking a look. I think it should be resolved now.

[va-an]

Thanks for working on this @sdmg15!
I have left a few suggestions, please have a look.

[sdmg15]

@va-an Applied some reviews and recommendation on 6724be5

I've also updated the PR description.

[va-an]

@sdmg15 thanks for update and for the detailed description!
Please take a look at the comments.

[va-an]

@sdmg15 thanks for update!
I've added some suggestions, pls have a look.

[va-an]

It would be better to rename it to parse_dns_recipient, because the function parses one recipient at a time.

[va-an]

It looks like you forgot to run cargo fmt 🙂 , please do so.

[va-an]

Suggested change

	#[cfg(feature = "dns_payment")]
	/// Resolves the given hrn payment instructions
	ResolveDnsRecipient { hrn: String , resolver: Option<String>},
	#[cfg(feature = "dns_payment")]
	/// Resolves BIP-353 DNS payment instructions for a human-readable name.
	ResolveDnsRecipient {
	/// Human-readable name (e.g. user@domain.com)
	hrn: String,
	/// DNS resolver address
	#[arg(long, default_value = "8.8.8.8")]
	resolver: String,
	},

This will make --help more useful:

-> % cargo run --all-features -- -n bitcoin resolve_dns_recipient --help
Resolves BIP-353 DNS payment instructions for a human-readable name

Usage: bdk-cli resolve_dns_recipient [OPTIONS] <HRN>

Arguments:
  <HRN>  Human-readable name (e.g. user@domain.com)

Options:
      --resolver <RESOLVER>  DNS resolver address [default: 8.8.8.8]
      --pretty               Output results in pretty format (instead of JSON)
  -h, --help                 Print help

Please note that the type for the resolver has changed.
See the suggested changes in the function itself.

[va-an]

Suggested change

	let mut ip_address = "8.8.8.8:53".to_string();
	if let Some(res_addr) = resolver_ip {
	ip_address = res_addr;
	}
	let ip_address = if resolver_ip.contains(':') {
	resolver_ip
	} else {
	format!("{resolver_ip}:53")
	};

Please note that resolver_ip should be passed to this function as a String (not Option<String>), because we added a default_value in commands.rs, as proposed here.

Also, in this suggestion I slightly changed the semantics — the user can provide an IP without a port (port 53 will be used), or with a port (the user-specified port will be used). In the vast majority of cases, a DNS server uses the standard port, so we can simplify this a bit for the user.

The error message when creating DNSHrnResolver needs to be updated, since the user may provide an invalid value and receive a confusing "Should not fail" error.