Skip to content

Minor additions to DDG native messaging test runner#780

Merged
neuronull merged 5 commits intomainfrom
neuronull/ddg-test-runner-instructions-updates
Mar 24, 2026
Merged

Minor additions to DDG native messaging test runner#780
neuronull merged 5 commits intomainfrom
neuronull/ddg-test-runner-instructions-updates

Conversation

@neuronull
Copy link
Copy Markdown
Contributor

@neuronull neuronull commented Mar 5, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33790

📔 Objective

While going through this process for the first time ever, I ran into a couple things that probably others would, so this PR proposes filling in the gaps.

📸 Screenshots

Comment thread docs/getting-started/clients/desktop/native-messaging-test-runner.md Outdated
@neuronull neuronull self-assigned this Mar 5, 2026
@neuronull neuronull requested a review from differsthecat March 5, 2026 21:33
@neuronull neuronull marked this pull request as ready for review March 5, 2026 21:33
@neuronull neuronull requested a review from a team as a code owner March 5, 2026 21:33
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 5, 2026

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4d54ad2
Status:⚡️  Build in progress...

View logs

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 5, 2026

Logo
Checkmarx One – Scan Summary & Detailsd913a6cd-7a6f-4cda-8137-99f3d7cbde96

Great job! No new security vulnerabilities introduced in this pull request

coltonhurst
coltonhurst previously approved these changes Mar 6, 2026
Copy link
Copy Markdown
Member

@differsthecat differsthecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments; this is a logistical doc on the native messaging test runner, so I don't think including the DDG browser in multiple places in it is what we want to do, but you do raise good points about including it.

I think a note or something can be added in the top section explaining that this does not provide full testing for the DDG integration, but is a useful tool to troubleshoot and test for many breaking bugs. To do a full, comprehensive test of the DDG integration, downloading the DDG browser and using that for testing is recommended.

Comment thread docs/getting-started/clients/desktop/native-messaging-test-runner.md Outdated
Comment thread docs/getting-started/clients/desktop/native-messaging-test-runner.md Outdated
Copy link
Copy Markdown
Member

@differsthecat differsthecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you, @neuronull ! 🙌 🦆

@neuronull neuronull enabled auto-merge (squash) March 24, 2026 16:29
@neuronull neuronull merged commit 668463c into main Mar 24, 2026
11 of 12 checks passed
@neuronull neuronull deleted the neuronull/ddg-test-runner-instructions-updates branch March 24, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants