[PM-33232] Update UX implemented in PM-33219 to resolve VULN-458#7204
[PM-33232] Update UX implemented in PM-33219 to resolve VULN-458#7204
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7204 +/- ##
==========================================
- Coverage 57.43% 57.42% -0.01%
==========================================
Files 2032 2032
Lines 89377 89432 +55
Branches 7944 7955 +11
==========================================
+ Hits 51331 51359 +28
- Misses 36203 36225 +22
- Partials 1843 1848 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
| else if (existingSend.AuthType == Core.Tools.Enums.AuthType.Email) | ||
|
|
||
| existingSend.AuthType = AuthType; |
There was a problem hiding this comment.
The older code handled the scenario where no auth type was sent by the client. We have to assume some older clients will still be sending send-related requests
There was a problem hiding this comment.
I've also updated the exception message to match the behavior change in 3c6e23f
There was a problem hiding this comment.
What if an older client is setting the password or email verification list (i.e. Emails or Password is set in the model), the auth type would be null and so the emails or password information would be lost
There was a problem hiding this comment.
I've made changes to use the presence of AuthType in the request to conditionally execute the new logic. 92d1a41
|
3 participants
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-33232
📔 Objective
Given a user has an existing 'Who can view' setting configured, when they switch the 'Who can view' option and select Save, then the previous 'Who can view' method is removed and replaced with the newly selected option
Given a user switches the 'Who can view' setting, when they select Save, then the updated setting is reflected immediately in the UI
Given a user switches the 'Who can view' setting, when they select Save, then the updated setting persists after leaving and returning to the screen
Given the above behavior, when tested across web, desktop, and mobile clients, then all clients reflect the same expected behavior