fix: avoid dangling-reference in sample tuple conversion for C++23 compatibility#423
Open
henryiii wants to merge 1 commit intoboostorg:developfrom
Open
fix: avoid dangling-reference in sample tuple conversion for C++23 compatibility#423henryiii wants to merge 1 commit intoboostorg:developfrom
henryiii wants to merge 1 commit intoboostorg:developfrom
Conversation
…mpatibility Under C++23 P2255R2 (Type Traits To Detect References Binding To Temporaries), std::tuple's converting constructor is deleted when a reference element would bind to a temporary. This broke code that converts tuple<int> to tuple<const double&>, since the int is first converted to a temporary double. Fix: strip cv-qualifiers and reference from the deduced sample argument types in accumulator_traits. This makes accumulator_traits<mean<double>>::args == tuple<double> instead of tuple<const double&>, so the compile-time convertibility check is_convertible<tuple<int>, tuple<double>> succeeds. Runtime behavior is unchanged; accumulators still receive arguments through their const double& parameter. Signed-off-by: Henry Schreiner <henryfs@princeton.edu> Assisted-by: OpenCode:Kimi-K2.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible alternative fix for #420.
🤖 Assisted-by: OpenCode:Kimi-K2.6