Closed
Conversation
Collaborator
Author
|
FYI I can't seem to get boost.build to default to C++11, which might cause some pain with this transition. |
jzmaddock
reviewed
Feb 25, 2021
| for(unsigned i = 0; i < m_used; ++i) | ||
| this->destroy(&m_data[i]); | ||
| this->deallocate(m_data, m_capacity); | ||
| #else |
Collaborator
There was a problem hiding this comment.
I think you've deleted the wrong branch here?
This will break C++17 as well I believe.
Collaborator
|
Looks good apart from the one comment. |
Collaborator
Author
|
I'm gonna leave this one until next release; clearly there are opportunities for silly mistakes. |
Member
|
Some of these have been hit already, and the rest will be in #956 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.