Replaced regular includes with ensure_resource() calls#81
Conversation
This is because the require_php() method did not see a minor version as the same as the latest patch version, but php::version then tries to add the duplicate definitions
|
I think that it would be better to move the calculation of the patch version from the minor version that's used to calculate the patch version at the top of the |
|
I've started a new PR at #82 to cover this problem. I haven't attempted the APC fix though. Suggest we close this and start a new one for APC once the other is merged. |
|
Happy to go with whatever, @sambauers. Any thoughts on how to consolidate the version checking code so we're not copy/pasting everywhere? |
|
Pretty sure #82 is about as DRY as it's going to get. We could write a generic extension building function, but I suspect the exceptions would make that messy pretty quickly. |
This is because the require_php() method did not see a minor version as the same as the latest patch version, but php::version then tries to add the duplicate definitions.