feat: Allow configurable timeout via environment variable#1926
Open
ttsuru wants to merge 2 commits intobrefphp:masterfrom
Open
feat: Allow configurable timeout via environment variable#1926ttsuru wants to merge 2 commits intobrefphp:masterfrom
ttsuru wants to merge 2 commits intobrefphp:masterfrom
Conversation
- The timeout value (in microseconds) is now configurable using the `BREF_FPM_READY_TIMEOUT` environment variable. - If the `BREF_FPM_READY_TIMEOUT` variable is not set, the default timeout is 5 seconds (5000000 microseconds).
|
Any chance of this being picked up? We need this because we are running into this a lot. In our case the upstream HTTP POST can take around 3-4 seconds and a hard stop of 2 seconds (the lambda is 10 seconds) is causing false alerts on our monitoring, Cheers, |
Member
|
Hey, sorry for the delay. I will review this but not this week unfortunately, this is a launch week + I'm moving to a conference talk so only focusing on urgent bugfixes. But I'll get back to this ASAP 👍 |
|
@mnapoli Any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREF_FPM_READY_TIMEOUTenvironment variable.BREF_FPM_READY_TIMEOUTvariable is not set, the default timeout is 5 seconds (5000000 microseconds).ref: #1917