Skip to content

fix: brev ls spinner hanging during onboarding quick tour#348

Open
hakhandelwal11 wants to merge 3 commits intomainfrom
BREV-6328/brevls-stuck-on-quick-tour
Open

fix: brev ls spinner hanging during onboarding quick tour#348
hakhandelwal11 wants to merge 3 commits intomainfrom
BREV-6328/brevls-stuck-on-quick-tour

Conversation

@hakhandelwal11
Copy link
Copy Markdown
Contributor

@hakhandelwal11 hakhandelwal11 commented Apr 4, 2026

After first login, the quick tour asks the user to run brev ls, which starts a spinner waiting for brev shell in another terminal. However, the spinner never stops because it checks HasRunBrevOpen instead of HasRunBrevShell, so the completion condition is never met.

Fix: Updated the condition in doBrevShellOnboarding. The polling loop now uses shellOnboardingPollDone(res), which considers onboarding complete when the onboarding state is non-nil and HasRunBrevShell is true. This ensures the spinner correctly detects completion and exits cleanly.

@hakhandelwal11 hakhandelwal11 self-assigned this Apr 4, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.69%. Comparing base (88dc335) to head (dd8a7a1).
⚠️ Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/hello/steps.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
+ Coverage   14.77%   17.69%   +2.91%     
==========================================
  Files         127      140      +13     
  Lines       16977    18483    +1506     
==========================================
+ Hits         2508     3270     +762     
- Misses      14182    14853     +671     
- Partials      287      360      +73     
Flag Coverage Δ
Linux 17.69% <0.00%> (+2.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hakhandelwal11 hakhandelwal11 marked this pull request as ready for review April 8, 2026 06:00
@hakhandelwal11 hakhandelwal11 requested a review from a team as a code owner April 8, 2026 06:00
@hakhandelwal11 hakhandelwal11 force-pushed the BREV-6328/brevls-stuck-on-quick-tour branch from 4ae202f to bcd8d8a Compare April 8, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant