feat: add brev open codex for remote Codex CLI sessions#352
Open
theFong wants to merge 5 commits intofeat/open-claudefrom
Open
feat: add brev open codex for remote Codex CLI sessions#352theFong wants to merge 5 commits intofeat/open-claudefrom
theFong wants to merge 5 commits intofeat/open-claudefrom
Conversation
Comment on lines
389
to
+393
| return breverrors.WrapAndTrace(err) | ||
| } | ||
| if strings.Contains(err.Error(), "failed to install Codex") { | ||
| return breverrors.WrapAndTrace(err) | ||
| } |
Contributor
There was a problem hiding this comment.
these just do the same thing as the base case, should it handlePathError instead?
theFong
force-pushed
the
feat/open-codex
branch
from
5074943 to
ee71378
Compare
theFong
force-pushed
the
feat/open-codex
branch
from
bcbf7f2 to
687a0eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codexas a new editor type forbrev open, mirroring theclaudeimplementationnpm install -g @openai/codexif not presentOPENAI_API_KEYenv var and forwarding only when the remote doesn't already have it set--separatorUsage
Test plan
go build ./...passesgo test ./pkg/cmd/open/...passesbrev open <instance> codexinstalls and launches codex remotely--flag passthrough works-ddirectory override works