Open
Conversation
Member
|
Thanks for being quick on the trigger here @calvinmetcalf! |
Contributor
Author
|
these errrors have nothing to do with this, but just flakiness from saucelabs |
Member
|
What is |
Contributor
Author
|
its for using the new buffer api the Buffer.alloc and Buffer.from stuff |
calvinmetcalf
force-pushed
the
constant-time
branch
from
186b16e to
bc593db
Compare
Contributor
Author
|
fixed and rebased |
dcousens
requested changes
Aug 9, 2018
Member
dcousens
left a comment
dcousens
left a comment
There was a problem hiding this comment.
Actually, check test feedback
test/timing-safe-equal.js
Outdated
|
|
||
| t.throws(function () { | ||
| timingSafeEqual(Buffer.from([1, 2, 3]), Buffer.from([1, 2])) | ||
| }, 'should throw when given buffers with different lengths') |
Member
There was a problem hiding this comment.
t.throws(fn, expected, msg)You are only doing
t.throws(fn, msg)You should check what exception is throwing.
Contributor
Author
|
from what I can tell, we have a problem with the saucelabs setup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.