Open
Conversation
They're only partially legacy since we carry the features in there too
abstract enough for you yet lol
This conversion originally happened in the actuator command manager, but was moved to message conversion. A fix happened to make sure that we heed the step limit versus the range in the v3 line ACM, and needed to be ported into this conversion to make sure the test still passes.
Rebasing after a 3 month hiatus. Note that many protocols will fail test runs.
ValueCmd and ValueWithParameterCmd should only take one value at a time. This means that we need to have the server break v1-v3 message with subcommands into multiple messages, parse those, then only return one succeed/fail status. This is done in the Xray/Check system in the server via making a new Checked*Vec type that just holds a vector of CheckedValue messages.
Remove the idea of subcommands from the library, simplifying the frontend APIs but requiring us to do timing and batching management in the server (which is fine)
Batch commands together instead of requiring users to know what needs to come in a packet. This requires adding feature UUIDs to each hardware command so we can know what to overwrite.
Used for comparisons in tests. These should use uuids, but it'll take a while to get all that in.
* JoyHub Enam * JoyHub Viv * JoyHub Vivara * JoyHub Explorer 2 * JoyHub Pipes * JoyHub Vigo
* Adorime Wearable Egg Vibrator * Adorime Male Masturbator * Adorime Penis Vibrator * Adorime Anal Vibrator * Adorime G-spot Rabbit Dildo Vibrator New identifier for Galaku Cannon-GT
* VVD Vkini * Sexverse Heart Back when I was talking to metaXsire (before they got weird) they told me they didn't do hardware anymore, and that anything metaXsire should really be "Sexverse", so I'm inclined to rename the protocols and get the metaXsire naming out of the codebase.
* BeYourLover Naughty Clock (Vibrator and Suction) * ToyCod Clara
Ported from Urica Guard buttplugio#723
Makes reading things easier.
As has been the case since 2017.
|
|
Member
|
Ok, so, first off, don't worry about resolving the conflicts here for now. We're still in a massive amount of flux around getting the new library version done so you'll be doing useless work on conflict resolution until things get stablized. I... haven't quite figured out if/how I'm bringing this in yet, mainly because we've got so many variables in flight already and this is gonna be a DCM used by a small subset of people. I'm not saying I'm kicking it out yet either. Just trying to maintain my workload/sanity for the moment. |
qdot
force-pushed
the
dev
branch
3 times, most recently
from
0f9713e to
e71d832
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds udp sockets as a transport/hardware manager.
Supports TMax OSR2, SR6, SSR1.
Configurable in json (address & port setting)