fix: correct boundary check in dynamic_offset check#4788
Merged
lum1n0us merged 1 commit intobytecodealliance:mainfrom Jan 20, 2026
Merged
fix: correct boundary check in dynamic_offset check#4788lum1n0us merged 1 commit intobytecodealliance:mainfrom
lum1n0us merged 1 commit intobytecodealliance:mainfrom
Conversation
kylo5aby
requested review from
TianlongLiang,
lum1n0us,
no1wudi and
yamt
as code owners
Signed-off-by: zhenweijin <zhenwei.jin@intel.com>
lum1n0us
approved these changes
Jan 19, 2026
lum1n0us
added
the
bug-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
correct boundary check in check_dynamic_offset_pop when dynamic_offset is 0. When
dynamic_offset = 0,check_dynamic_offset_popwill always return true, which may wrongly updatedynamic_offset.also include a typo fix in
SET_OPERAND_REF