thread Reactor through with a global #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchickey
force-pushed
the
pch/global_reactor
branch
2 times, most recently
from
942a845 to
b43c699
Compare
This was referenced Nov 19, 2024
yoshuawuyts
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of asking the user to thread a Reactor through their program, keep a singleton that is accessible via
Reactor::current(). This accessor will panic when called outside of aruntime::block_on, which is a possible footgun that I don't think will be common in practice.wstd::runtimenow contains athread_local! { pub(crate) static REACTOR: RefCell<Option<Reactor>> }.runtime::block_onpopulates the RefCell and clears it after the future completes, so it no longer takes aFnOnce(Reactor) -> Futbut just a plainFutureargument.Reactor::currentreturns a clone (cheap, because Rc) of the reactor in the cell.Eliminating the
&'a Reactorfrom a bunch of structs, in favor of callingReactor::current()at each use site, means we could eliminate the lifetime parameter from many of the structs.