-
Notifications
You must be signed in to change notification settings - Fork 297
feat: add thumbSize to set size of thumb #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
BartoszKlonowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far I have some cosmetic comments and a question before I'll dive deeper into the implementation itself.
|
Hello @bdtren, let me know please if you plan to push this forward, or should I take it from here? |
|
Hi @BartoszKlonowski , |
…thumbImage change. Remove comments via fb
|
Hi @BartoszKlonowski , |
Summary:
This PR adds a new thumbSize prop to control the thumb’s size for both with and without thumb image. It is a simple feature that I need and did patch-package in some of my projects but I didn't have a chance to contribute, I think some developers might also need it:
Test Plan:
Verify in the example list:
“Custom thumb size (no image)” renders a larger thumb (e.g. thumbSize={32}) tinted with thumbTintColor.
“Custom thumb size (scaled image)” renders the thumb image scaled to the configured size (e.g. thumbSize={60}).
Verify the same two examples behave equivalently on iOS (thumb resizes; image scales when provided).